fix: update tool-call extraction logic for Pi session JSONL

Refine parsing of assistant tool calls in review.sh to handle "toolCall" and "arguments" structures, aligning with Pi session format changes.

action.yml

@@ -18,6 +18,10 @@ inputs:
     description: "Custom API base URL (for OpenAI-compatible providers). Ignored for built-in providers."
     required: false
     default: ""
+  server_url:
+    description: "Override the Gitea/GitHub server URL used for API calls (e.g. http://server:3000 for internal routing inside the runner). Defaults to the auto-detected server URL."
+    required: false
+    default: ""
   token:
     description: "Git platform token for posting PR comments"
     required: true

entrypoint.sh

@@ -11,6 +11,7 @@ export PI_API_KEY="${INPUT_API_KEY}"
 export PI_PROVIDER="${INPUT_PROVIDER:-zai}"
 export PI_MODEL="${INPUT_MODEL:-glm-5.1}"
 export PI_BASE_URL="${INPUT_BASE_URL:-}"
+export PI_SERVER_URL="${INPUT_SERVER_URL:-}"
 export PI_TOOLS="${INPUT_TOOLS:-read,grep,find,ls}"
 export PI_REVIEW_PROMPT="${INPUT_REVIEW_PROMPT:-}"
 export PI_EXCLUDE="${INPUT_EXCLUDE_PATTERNS:-*.lock package-lock.json yarn.lock pnpm-lock.yaml *.min.js *.min.css *.map}"

scripts/review.sh

@@ -78,20 +78,44 @@ echo "Generate diff"
 # Instead, we get the diff directly from the Gitea/GitHub API using the token
 # we already have for posting comments.
 
-# Detect platform and resolve PR info
+# Gitea Actions mirrors GitHub Actions env vars ($GITHUB_*) and exposes the
-if [ -n "${GITEA_SERVER_URL:-}" ]; then
+# event payload at $GITHUB_EVENT_PATH. There is no flat $GITEA_EVENT_*
-  API_BASE="${GITEA_SERVER_URL}/api/v1"
+# variable for the PR number, so we parse it out of the event JSON.
-  PR_NUMBER="${GITEA_EVENT_PULL_REQUEST_NUMBER:-}"
+
-  REPO="${GITEA_REPOSITORY:-}"
+REPO="${GITHUB_REPOSITORY:-${GITEA_REPOSITORY:-}}"
-  echo "Platform: Gitea (${GITEA_SERVER_URL})"
+
+# Detect Gitea vs GitHub. Gitea sets $GITHUB_SERVER_URL too, so the only
+# reliable signal is $GITEA_ACTIONS (or a non-github.com server URL).
+#
+# $PI_SERVER_URL (server_url input) overrides the auto-detected server URL.
+# Gitea reports its *external* hostname (e.g. git.example.com), which may not
+# be routable from inside the runner's container network. Setting server_url
+# to the internal address (e.g. http://server:3000) fixes API calls.
+SERVER_URL="${PI_SERVER_URL:-${GITHUB_SERVER_URL:-${GITEA_SERVER_URL:-}}}"
+if [ -n "${GITEA_ACTIONS:-}" ] || { [ -n "$SERVER_URL" ] && [ "${SERVER_URL#*github.com}" = "$SERVER_URL" ]; }; then
+  API_BASE="${SERVER_URL}/api/v1"
+  PLATFORM="gitea"
+  echo "Platform: Gitea (${SERVER_URL})"
 else
   API_BASE="${GITHUB_API_URL:-https://api.github.com}"
-  PR_NUMBER="${GITHUB_EVENT_PULL_REQUEST_NUMBER:-}"
+  PLATFORM="github"
-  REPO="${GITHUB_REPOSITORY:-}"
   echo "Platform: GitHub"
 fi
 
+# Resolve PR number from the event payload.
+PR_NUMBER=""
+if [ -n "${GITHUB_EVENT_PATH:-}" ] && [ -f "${GITHUB_EVENT_PATH}" ]; then
+  PR_NUMBER=$(node -e "
+    try {
+      const e = require(process.env.GITHUB_EVENT_PATH);
+      const n = (e.pull_request && e.pull_request.number) || e.number || '';
+      process.stdout.write(String(n || ''));
+    } catch { process.stdout.write(''); }
+  ")
+fi
+
 echo "Repo: ${REPO}, PR: ${PR_NUMBER}"
+echo "DEBUG: PLATFORM=${PLATFORM} API_BASE=${API_BASE} EVENT=${GITHUB_EVENT_PATH:-}"
 
 if [ -z "$PR_NUMBER" ]; then
   echo "Not a pull request event. Skipping review."
@@ -109,55 +133,45 @@ const apiBase = '${API_BASE}';
 const repo = '${REPO}';
 const prNumber = '${PR_NUMBER}';
 const token = '${PI_TOKEN}';
+const platform = '${PLATFORM}';
 const maxBytes = ${PI_MAX_DIFF:-80000};
 
 function fetchDiff() {
   return new Promise((resolve, reject) => {
-    // Try Gitea diff endpoint first
+    // Gitea:  GET {api}/repos/{owner}/{repo}/pulls/{n}.diff
-    const giteaPath = '/repos/' + repo + '/pulls/' + prNumber + '.diff';
+    // GitHub: GET {api}/repos/{owner}/{repo}/pulls/{n} with Accept: application/vnd.github.v3.diff
-    const githubPath = '/repos/' + repo + '/pulls/' + prNumber;
+    const path = platform === 'gitea'
+      ? '/repos/' + repo + '/pulls/' + prNumber + '.diff'
+      : '/repos/' + repo + '/pulls/' + prNumber;
 
-    const url = new URL(apiBase + giteaPath);
+    const url = new URL(apiBase + path);
     const transport = url.protocol === 'http:' ? http : https;
 
+    const headers = {
+      'Authorization': 'token ' + token,
+      'User-Agent': 'pi-code-review',
+      'Accept': platform === 'gitea' ? 'text/plain' : 'application/vnd.github.v3.diff',
+    };
+
     const options = {
       hostname: url.hostname,
       port: url.port || (url.protocol === 'http:' ? 80 : 443),
       path: url.pathname,
       method: 'GET',
-      headers: {
+      headers,
-        'Authorization': 'token ' + token,
-        'Accept': 'text/plain',
-      },
     };
 
     const req = transport.request(options, (res) => {
-      if (res.statusCode === 404 && apiBase.indexOf('github.com') !== -1) {
-        // Fallback to GitHub diff format
-        reject(new Error('GitHub fallback not implemented'));
-        return;
-      }
       if (res.statusCode < 200 || res.statusCode >= 300) {
         let body = '';
         res.on('data', (c) => { body += c; });
-        res.on('end', () => { reject(new Error('API ' + res.statusCode + ': ' + body.slice(0, 200))); });
+        res.on('end', () => { reject(new Error('API ' + res.statusCode + ' for ' + url.href + ': ' + body.slice(0, 200))); });
         return;
       }
 
       let data = '';
-      let bytes = 0;
+      res.on('data', (chunk) => { data += chunk; });
-      res.on('data', (chunk) => {
+      res.on('end', () => { resolve(data); });
-        bytes += chunk.length;
-        if (maxBytes > 0 && bytes <= maxBytes) {
-          data += chunk;
-        }
-      });
-      res.on('end', () => {
-        if (maxBytes > 0 && data.length >= maxBytes) {
-          data = data.slice(0, maxBytes) + '\\n... (truncated at ' + maxBytes + ' bytes)';
-        }
-        resolve(data);
-      });
     });
     req.on('error', (e) => { reject(e); });
     req.end();
@@ -241,14 +255,21 @@ if [ ! -s /tmp/pi-review.md ]; then
   exit 1
 fi
 
+echo "Debug mode: PI_DEBUG=${PI_DEBUG}"
+
 # If debug mode, extract tool calls from session and append to review
 if [ "${PI_DEBUG}" = "true" ]; then
+  echo "Session dir contents:"
+  find /tmp/pi-session -type f 2>/dev/null || echo "  (none)"
   SESSION_FILE=$(find /tmp/pi-session -name '*.jsonl' -type f 2>/dev/null | head -1)
+  echo "Session file: ${SESSION_FILE:-<none found>}"
   TOOL_LOG=""
 
   if [ -n "${SESSION_FILE}" ]; then
-    # Extract tool-use entries: each line is a JSON object.
+    # Extract tool-call entries from Pi session JSONL.
-    # Tool calls appear as messages with tool_use/function_call content.
+    # Pi stores assistant messages with content blocks of type "toolCall"
+    # (NOT the Anthropic SDK's "tool_use"), using "arguments" (NOT "input").
+    # Tool results are separate entries with role "toolResult".
     TOOL_LOG=$(node -e "
       const fs = require('fs');
       const lines = fs.readFileSync('${SESSION_FILE}', 'utf8').trim().split('\n');
@@ -256,20 +277,18 @@ if [ "${PI_DEBUG}" = "true" ]; then
       for (const line of lines) {
         try {
           const entry = JSON.parse(line);
-          if (entry.type === 'message') {
+          if (entry.type !== 'message') continue;
           const msg = entry.message;
-            // Model requesting tool use
+          if (!msg || !msg.content) continue;
-            if (msg.role === 'assistant' && msg.content) {
           const parts = Array.isArray(msg.content) ? msg.content : [msg.content];
           for (const part of parts) {
-                if (typeof part === 'object' && part.type === 'tool_use') {
+            if (typeof part !== 'object') continue;
-                  const input = part.input || {};
+            if (part.type === 'toolCall') {
-                  const args = Object.entries(input).map(([k,v]) => k + '=' + JSON.stringify(v)).join(' ');
+              const args = Object.entries(part.arguments || {})
+                .map(([k,v]) => k + '=' + JSON.stringify(v)).join(' ');
               entries.push('[tool:' + part.name + '] ' + args);
             }
           }
-            }
-          }
         } catch {}
       }
       console.log(entries.join('\n'));
@@ -302,17 +321,7 @@ echo "::endgroup::"
 # ─── Phase 4: Post comment ────────────────────────────────────────────────────
 echo "::group::Post review comment"
 
-# Detect Gitea vs GitHub
+# API_BASE / REPO / PR_NUMBER were resolved in Phase 2.
-if [ -n "${GITEA_SERVER_URL:-}" ]; then
-  API_BASE="${GITEA_SERVER_URL}/api/v1"
-  PR_NUMBER="${GITEA_EVENT_PULL_REQUEST_NUMBER:-}"
-  REPO="${GITEA_REPOSITORY:-}"
-else
-  API_BASE="${GITHUB_API_URL:-https://api.github.com}"
-  PR_NUMBER="${GITHUB_EVENT_PULL_REQUEST_NUMBER:-}"
-  REPO="${GITHUB_REPOSITORY:-}"
-fi
-
 if [ -z "$PR_NUMBER" ]; then
   echo "Not a pull request event. Review written to /tmp/pi-review.md only."
   echo "::endgroup::"